Convert add_game.js to TypeScript (issue #17)

- Add ts/utils.ts: fully-typed port of utils.js (onSwap, toISOUTCString,
  syncSelectInputUntilChanged, conditionalElementHandler, disableElementsWhen*,
  getValueFromProperty). Uses document.querySelector throughout; fixes
  removeEventListener bug (was passing function reference instead of named
  listener); uses boolean disabled property instead of string "disabled"/""
- Add ts/add_game.ts: TypeScript conversion of add_game.js, imports
  syncSelectInputUntilChanged from ts/utils.ts (resolves to dist/utils.js
  at runtime)
- Update add_game view to serve compiled dist/add_game.js

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
2026-06-19 13:06:58 +02:00
parent ce5e5fb729
commit 4f535be270
3 changed files with 238 additions and 1 deletions
+1 -1
View File
@@ -180,7 +180,7 @@ def add_game(request: HttpRequest) -> HttpResponse:
), ),
), ),
title="Add New Game", title="Add New Game",
scripts=ModuleScript("search_select.js") + ModuleScript("add_game.js"), scripts=ModuleScript("search_select.js") + ModuleScript("dist/add_game.js"),
) )
+12
View File
@@ -0,0 +1,12 @@
import { syncSelectInputUntilChanged } from "./utils.js";
const syncData = [
{
source: "#id_name",
source_value: "value",
target: "#id_sort_name",
target_value: "value",
},
];
syncSelectInputUntilChanged(syncData, "form");
+225
View File
@@ -0,0 +1,225 @@
declare const htmx: any;
/**
* Runs initializeElement once for each element matching selector, on initial
* page load and inside every htmx-swapped fragment (a port of FastHTML's
* proc_htmx). htmx fires htmx:load for the initial document and for each
* swapped-in element, so a single registration covers both; the WeakSet
* guarantees once-per-element initialization, replacing the old
* DOMContentLoaded + htmx:afterSwap + per-element guard-flag pattern.
*/
function onSwap(selector: string, initializeElement: (element: Element) => void) {
const initialized = new WeakSet();
htmx.onLoad((swappedElement: Element) => {
const elements: Element[] = Array.from(htmx.findAll(swappedElement, selector));
if (swappedElement.matches && swappedElement.matches(selector)) {
elements.unshift(swappedElement);
}
for (const element of elements) {
if (initialized.has(element)) continue;
initialized.add(element);
initializeElement(element);
}
});
}
/** Formats Date to a UTC string accepted by the datetime-local input field. */
function toISOUTCString(date: Date): string {
function stringAndPad(number: number) {
return number.toString().padStart(2, "0");
}
const year = date.getFullYear();
const month = stringAndPad(date.getMonth() + 1);
const day = stringAndPad(date.getDate());
const hours = stringAndPad(date.getHours());
const minutes = stringAndPad(date.getMinutes());
return `${year}-${month}-${day}T${hours}:${minutes}`;
}
/**
* Mirrors each source element's value onto its target until the target is
* focused (manual edit wins). Each syncData entry maps a source selector and
* property onto a target selector and property.
*/
function syncSelectInputUntilChanged(syncData: Array<{ source: string; target: string; source_value: string; target_value: string }>, parentSelector: string | Document = document) {
const parentElement =
parentSelector === document
? document
: document.querySelector(parentSelector as string);
if (!parentElement) {
console.error(`The parent selector "${parentSelector}" is not valid.`);
return;
}
// Set up a single change event listener on the document for handling all source changes
parentElement.addEventListener("change", function (event) {
// Loop through each sync configuration item
syncData.forEach((syncItem: { source: string; target: string; source_value: string; target_value: string }) => {
// Check if the change event target matches the source selector
if ((event.target as HTMLElement).matches(syncItem.source)) {
if (!event.target) return;
const sourceElement = event.target;
const valueToSync = getValueFromProperty(
sourceElement,
syncItem.source_value
);
const targetElement = document.querySelector<HTMLSelectElement>(syncItem.target);
if (targetElement && valueToSync !== null) {
console.log(`Changing value of ${syncItem.target} to ${valueToSync}`);
(targetElement as unknown as Record<string, unknown>)[syncItem.target_value] = valueToSync;
}
}
});
});
// Set up a single focus event listener on the document for handling all target focuses
const syncListener = (event: Event) => {
// Loop through each sync configuration item
syncData.forEach((syncItem: { source: string; target: string; source_value: string; target_value: string }) => {
// Check if the focus event target matches the target selector
if ((event.target as HTMLElement).matches(syncItem.target)) {
// Remove the change event listener to stop syncing
// This assumes you want to stop syncing once any target receives focus
// You may need a more sophisticated way to remove listeners if you want to stop
// syncing selectively based on other conditions
document.removeEventListener("change", syncListener);
}
});
}
parentElement.addEventListener(
"focus",
syncListener,
true
); // Use capture phase to ensure the event is captured during focus, not bubble
}
/**
* Reads a property off the source element. For a <select>, reads from its
* selected option. A "dataset." prefix reads from the element's data-* set.
*/
function getValueFromProperty(sourceElement: EventTarget, property: string): any {
let source: HTMLElement | HTMLOptionElement =
sourceElement instanceof HTMLSelectElement
? sourceElement.selectedOptions[0]
: sourceElement as HTMLElement;
if (property.startsWith("dataset.")) {
let datasetKey = property.slice(8); // Remove 'dataset.' part
return source.dataset[datasetKey];
} else if (property in source) {
return (source as unknown as Record<string, unknown>)[property];
} else {
console.error(`Property ${property} is not valid for the option element.`);
return null;
}
}
type ElementHandlerConfig = [
condition: () => boolean, // condition function
targetElements: string[], // array of target element selectors
callbackfn1: (el: HTMLElement) => void, // callback function for matched condition
callbackfn2: (el: HTMLElement) => void // callback function for unmatched condition
];
/**
* For each config, runs callbackfn1 on every target element when condition()
* is true, callbackfn2 otherwise. See ElementHandlerConfig for the tuple shape.
*/
function conditionalElementHandler(...configs: ElementHandlerConfig[]) {
configs.forEach(([condition, targetElements, callbackfn1, callbackfn2]) => {
if (condition()) {
targetElements.forEach((elementName) => {
let el = document.querySelector<HTMLElement>(elementName);
if (el === null) {
console.error(`Element ${elementName} doesn't exist.`);
} else {
callbackfn1(el);
}
});
} else {
targetElements.forEach((elementName) => {
let el = document.querySelector<HTMLElement>(elementName);
if (el === null) {
console.error(`Element ${elementName} doesn't exist.`);
} else {
callbackfn2(el);
}
});
}
});
}
function disableElementsWhenValueNotEqual(
targetSelect: string,
targetValue: string | string[],
elementList: string[]
) {
return conditionalElementHandler([
() => {
let target = document.querySelector<HTMLSelectElement>(targetSelect);
if (!target) return false;
console.debug(
`${disableElementsWhenTrue.name}: triggered on ${target.id}`
);
console.debug(`
${disableElementsWhenTrue.name}: matching against value(s): ${targetValue}`);
if (targetValue instanceof Array) {
if (targetValue.every((value) => target.value != value)) {
console.debug(
`${disableElementsWhenTrue.name}: none of the values is equal to ${target.value}, returning true.`
);
return true;
}
return false;
} else {
console.debug(
`${disableElementsWhenTrue.name}: none of the values is equal to ${target.value}, returning true.`
);
return target.value != targetValue;
}
},
elementList,
(el) => {
console.debug(
`${disableElementsWhenTrue.name}: evaluated true, disabling ${el.id}.`
);
(el as HTMLInputElement).disabled = true;
},
(el) => {
console.debug(
`${disableElementsWhenTrue.name}: evaluated false, NOT disabling ${el.id}.`
);
(el as HTMLInputElement).disabled = false;
},
]);
}
function disableElementsWhenTrue(targetSelect: string, targetValue: string | string[], elementList: string[]) {
return conditionalElementHandler([
() => {
console.log(`${disableElementsWhenTrue.name}: triggered on ${targetSelect}`)
console.log(`Value of ${targetSelect} is ${targetValue}: ${document.querySelector<HTMLSelectElement>(targetSelect)?.value == targetValue}`)
return document.querySelector<HTMLSelectElement>(targetSelect)?.value == targetValue;
},
elementList,
(el) => {
console.log(`${disableElementsWhenTrue.name}: disabling ${el.id}`);
(el as HTMLInputElement).disabled = true;
},
(el) => {
console.log(`${disableElementsWhenTrue.name}: enabling ${el.id}`);
(el as HTMLInputElement).disabled = false;
},
]);
}
export {
onSwap,
toISOUTCString,
syncSelectInputUntilChanged,
conditionalElementHandler,
disableElementsWhenValueNotEqual,
disableElementsWhenTrue,
getValueFromProperty,
};