Address PR review: combobox field layout and dark-mode contrast
- Wire the long-defined-but-unused _FIELD_CLASS into the container so pills and the search input form a single padded flex row; the flex-1 input now fills the widget instead of looking unclickable inside a larger box (affects both SearchSelect and FilterSelect via the shared shell). - Filter option labels get text-body so they're readable on dark backgrounds. - Filter +/- buttons get text-body (readable at rest) and hover:border-brand-strong so the border stays visible against the brand hover fill. - Mirror the filter class changes in search_select.js and rebuild base.css. https://claude.ai/code/session_01XzhXvMvw42CQGc9kmin3GS
This commit is contained in:
@@ -44,11 +44,12 @@
|
||||
var FILTER_OPTION_ROW_CLASS =
|
||||
"flex items-center justify-between px-2 py-1 rounded text-sm " +
|
||||
"hover:bg-neutral-secondary-strong cursor-pointer";
|
||||
var FILTER_OPTION_LABEL_CLASS = "truncate";
|
||||
var FILTER_OPTION_LABEL_CLASS = "truncate text-body";
|
||||
var FILTER_OPTION_BUTTONS_CLASS = "flex gap-1 ml-2 shrink-0";
|
||||
var FILTER_ACTION_BUTTON_CLASS =
|
||||
"w-5 h-5 flex items-center justify-center text-xs font-bold rounded " +
|
||||
"border border-default-medium hover:bg-brand hover:text-white hover:border-brand";
|
||||
"w-5 h-5 flex items-center justify-center text-xs font-bold rounded text-body " +
|
||||
"border border-default-medium " +
|
||||
"hover:bg-brand hover:text-white hover:border-brand-strong";
|
||||
|
||||
var DEBOUNCE_MS = 500;
|
||||
|
||||
|
||||
Reference in New Issue
Block a user