From 8637c547e439d28bcc4504bcdb86d297c17b8a80 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Luk=C3=A1=C5=A1=20Kucharczyk?= <lukas@kucharczyk.xyz>
Date: Sat, 20 Jun 2026 21:37:44 +0200
Subject: [PATCH] refactor(session): address review minors for issue #53

- SessionRowData.cell_data: list[Node | str] (date cells are str)
- strengthen test_session_row_fragment_via_htmx to assert OOB navbar

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
---
 games/views/session.py       | 2 +-
 tests/test_rendered_pages.py | 6 +++++-
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/games/views/session.py b/games/views/session.py
index 3fa7724..de5bef0 100644
--- a/games/views/session.py
+++ b/games/views/session.py
@@ -46,7 +46,7 @@ class SessionRowData(TypedDict):
     hx_get: str
     hx_select: str
     hx_swap: str
-    cell_data: list[Node]
+    cell_data: list[Node | str]
 
 
 def session_row_data(session: Session, device_list, csrf_token: str) -> SessionRowData:
diff --git a/tests/test_rendered_pages.py b/tests/test_rendered_pages.py
index 89668d6..c8dec68 100644
--- a/tests/test_rendered_pages.py
+++ b/tests/test_rendered_pages.py
@@ -255,13 +255,17 @@ class RenderedPagesTest(TestCase):
         self.assertNoEscapedTags(html)
 
     def test_session_row_fragment_via_htmx(self):
-        # The inline "finish session" endpoint returns a <tr> fragment.
+        # The inline "finish session" endpoint returns an in-place row swap
+        # (<tr id="session-row-{pk}">) plus an OOB navbar-playtime update.
         resp = self.client.get(
             reverse("games:list_sessions_end_session", args=[self.session.id]),
             HTTP_HX_REQUEST="true",
         )
         html = resp.content.decode()
         self.assertTrue(html.lstrip().startswith("<tr"))
+        self.assertIn(f'id="session-row-{self.session.id}"', html)
+        self.assertIn('id="navbar-playtime"', html)
+        self.assertIn('hx-swap-oob="true"', html)
         self.assertIn(self.game.name, html)
         self.assertNoEscapedTags(html)