From c1882f66e31e832e94b08c4ac04219220d25077f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Luk=C3=A1=C5=A1=20Kucharczyk?= <lukas@kucharczyk.xyz>
Date: Mon, 15 Apr 2024 13:55:17 +0200
Subject: [PATCH] Improve purchase name consistency on stats page

---
 CHANGELOG.md               |  1 +
 games/templates/stats.html | 21 ++++++++++++---------
 2 files changed, 13 insertions(+), 9 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 83c1133..323848b 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -9,6 +9,7 @@
 * mark refunded purchases red on game overview
 * increase session count on game overview when starting a new session
 * game overview: sort purchases also by date purchased (on top of date released)
+* stats: improve purchase name consistency
 
 ## Fixed
 * Fix title not being displayed on the Recent sessions page
diff --git a/games/templates/stats.html b/games/templates/stats.html
index e7ca87c..2e12636 100644
--- a/games/templates/stats.html
+++ b/games/templates/stats.html
@@ -3,6 +3,15 @@
     {{ title }}
 {% endblock title %}
 {% load static %}
+
+{% partialdef purchase-name %}
+    {% if purchase.type != 'game' %}
+        {{ purchase.name }} ({{ purchase.edition.name }} {{ purchase.get_type_display }})
+    {% else %}
+        {{ purchase.edition.name }}
+    {% endif %}
+{% endpartialdef %}
+
 {% block content %}
     <div class="dark:text-white max-w-sm sm:max-w-xl lg:max-w-3xl mx-auto">
         <div class="flex justify-center items-center">
@@ -172,11 +181,7 @@
                         <td class="px-2 sm:px-4 md:px-6 md:py-2 font-mono">
                             <a class="underline decoration-slate-500 sm:decoration-2"
                                href="{% url 'edit_purchase' purchase.id %}">
-                                {% if purchase.type == 'dlc' %}
-                                    {{ purchase.name }} ({{ purchase.edition.name }} DLC)
-                                {% else %}
-                                    {{ purchase.edition.name }}
-                                {% endif %}
+                                {% partial purchase-name %}
                             </a>
                         </td>
                         <td class="px-2 sm:px-4 md:px-6 md:py-2 font-mono">{{ purchase.date_finished | date:"d/m/Y" }}</td>
@@ -240,8 +245,7 @@
                         <td class="px-2 sm:px-4 md:px-6 md:py-2 font-mono">
                             <a class="underline decoration-slate-500 sm:decoration-2"
                                href="{% url 'edit_purchase' purchase.id %}">
-                                {{ purchase.edition.name }}
-                                {% if purchase.type == "dlc" %}({{ purchase.name }}, {{ purchase.get_type_display }}){% endif %}
+                               {% partial purchase-name %}
                             </a>
                         </td>
                         <td class="px-2 sm:px-4 md:px-6 md:py-2 font-mono">{{ purchase.price }}</td>
@@ -266,8 +270,7 @@
                         <td class="px-2 sm:px-4 md:px-6 md:py-2 font-mono">
                             <a class="underline decoration-slate-500 sm:decoration-2"
                                href="{% url 'edit_purchase' purchase.id %}">
-                                {{ purchase.edition.name }}
-                                {% if purchase.type != "game" %}({{ purchase.name }}, {{ purchase.get_type_display }}){% endif %}
+                               {% partial purchase-name %}
                             </a>
                         </td>
                         <td class="px-2 sm:px-4 md:px-6 md:py-2 font-mono">{{ purchase.price }}</td>