timetracker

lukas/timetracker

Fork 0

Commit Graph

Author	SHA1	Message	Date
lukas	5bb8b92c05	Fix add-form JS: name→sort-name sync and related-game disable Two bugs in the add forms, both root-caused via the e2e harness: 1. add_game Name → Sort name never synced. syncSelectInputUntilChanged was scoped to "form", but the first <form> on every page is the navbar logout form — the add-form fields live in a later form, so the delegated listener never heard their events. Scope to "#add-form" (the add-form wrapper). Also switch the sync from the "change" event to "input" so Sort name mirrors Name live as you type, not only on blur. 2. add_purchase Related game not disabled when Type == Game. disableElementsWhenTrue set `.disabled` on #id_related_game, which is the SearchSelect wrapper <div> (a <div> ignores `disabled`). Target the inner [data-search-select-search] input instead, so the widget is actually disabled. Adds two e2e regression tests (live sync; type-game disables the related-game search input and re-enables it for other types). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>	2026-06-19 18:11:49 +02:00
lukas	4f535be270	Convert add_game.js to TypeScript (issue #17 ) - Add ts/utils.ts: fully-typed port of utils.js (onSwap, toISOUTCString, syncSelectInputUntilChanged, conditionalElementHandler, disableElementsWhen*, getValueFromProperty). Uses document.querySelector throughout; fixes removeEventListener bug (was passing function reference instead of named listener); uses boolean disabled property instead of string "disabled"/"" - Add ts/add_game.ts: TypeScript conversion of add_game.js, imports syncSelectInputUntilChanged from ts/utils.ts (resolves to dist/utils.js at runtime) - Update add_game view to serve compiled dist/add_game.js Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>	2026-06-19 13:11:14 +02:00

Author

SHA1

Message

Date

lukas

5bb8b92c05

Fix add-form JS: name→sort-name sync and related-game disable

Two bugs in the add forms, both root-caused via the e2e harness:

1. add_game Name → Sort name never synced. syncSelectInputUntilChanged was
   scoped to "form", but the first <form> on every page is the navbar logout
   form — the add-form fields live in a later form, so the delegated listener
   never heard their events. Scope to "#add-form" (the add-form wrapper). Also
   switch the sync from the "change" event to "input" so Sort name mirrors Name
   live as you type, not only on blur.

2. add_purchase Related game not disabled when Type == Game.
   disableElementsWhenTrue set `.disabled` on #id_related_game, which is the
   SearchSelect wrapper <div> (a <div> ignores `disabled`). Target the inner
   [data-search-select-search] input instead, so the widget is actually disabled.

Adds two e2e regression tests (live sync; type-game disables the related-game
search input and re-enables it for other types).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

2026-06-19 18:11:49 +02:00

lukas

4f535be270

Convert add_game.js to TypeScript (issue #17 )

- Add ts/utils.ts: fully-typed port of utils.js (onSwap, toISOUTCString,
  syncSelectInputUntilChanged, conditionalElementHandler, disableElementsWhen*,
  getValueFromProperty). Uses document.querySelector throughout; fixes
  removeEventListener bug (was passing function reference instead of named
  listener); uses boolean disabled property instead of string "disabled"/""
- Add ts/add_game.ts: TypeScript conversion of add_game.js, imports
  syncSelectInputUntilChanged from ts/utils.ts (resolves to dist/utils.js
  at runtime)
- Update add_game view to serve compiled dist/add_game.js

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

2026-06-19 13:11:14 +02:00

2 Commits