lukas
/
timetracker
1
0
Fork 0
Code Issues 17 Pull Requests 4 Actions Packages Projects 1 Releases 20 Wiki Activity

Make start session and finish session not reload the whole page #52

New Issue
Closed
opened 2023-09-20 16:52:26 +00:00 by lukas · 3 comments
lukas commented 2023-09-20 16:52:26 +00:00
Owner
Copy Link

This is very slow.

This is very slow.
lukas closed this issue 2023-09-20 16:55:31 +00:00
lukas reopened this issue 2023-09-20 16:55:38 +00:00
lukas commented 2023-09-20 17:03:35 +00:00
Author
Owner
Copy Link

Not closing yet because the current solution is POC at best.

Using HTMX (https://htmx.org) we start/end session using AJAX and then replace parts of the page without reloading.
However, these need to be fixed/improved before it would be considered fixed:

  • The hx-select are suuuper ugly and hacky
    ** This is because the session list "table" is rendered using grid
    *** This means instead of being able to replace a single row, we have to use 2x :nth-child CSS selectors to select a range of divs. VERY BAD. #53
    *** This also means we cannot use HTMX to only get nice partial HTML, instead we render the whole page and select only part of it. Probably still slow despite not reloading the whole page.
Not closing yet because the current solution is POC at best. Using HTMX (https://htmx.org) we start/end session using AJAX and then replace parts of the page without reloading. However, these need to be fixed/improved before it would be considered fixed: * The `hx-select` are suuuper ugly and hacky ** This is because the session list "table" is rendered using grid *** This means instead of being able to replace a single row, we have to use 2x `:nth-child` CSS selectors to select a range of `div`s. VERY BAD. #53 *** This also means we cannot use HTMX to only get nice partial HTML, instead we render the whole page and select only part of it. Probably still slow despite not reloading the whole page.
lukas added a new dependency 2023-09-20 17:04:03 +00:00
#53 Render session list as table
lukas commented 2023-11-17 20:31:42 +00:00
Author
Owner
Copy Link

I've already did a POC of returning HTML partials with Django in 3f037b4c7c, additionally there are packages for improving working with partials.

Further reading:

I've already did a POC of returning HTML partials with Django in 3f037b4c7c, additionally there are packages for improving working with partials. Further reading: - https://github.com/spookylukey/django-htmx-patterns/blob/master/separate_partials.rst - https://mitchel.me/slippers/docs/introduction/ - https://github.com/carltongibson/django-template-partials
lukas commented 2024-01-10 14:55:50 +00:00
Author
Owner
Copy Link

Done properly in 0cf3411f63 and 44f49e5974

Done properly in 0cf3411f6335be8fe8611d858189c450985a48fa and 44f49e597483a34b9a8792841254505987260949
lukas closed this issue 2024-01-10 14:55:51 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
main
filters_finally
filters-wip
filters
css_experiment
purchase_state
add-frontend
switch-to-react
fix-splitdatetimefield
fix-csrf
1.5.2
1.5.1
1.5.0
1.4.0
1.3.0
1.2.0
1.1.2
1.1.1
1.1.0
1.0.3
1.0.2
1.0.1
1.0.0
0.2.5
0.2.4
0.2.3
0.2.2
0.2.1
0.2.0
0.1.4
0.1.3
0.1.2
0.1.1
0.1.0
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Depends on
#53 Render session list as table
lukas/timetracker
Reference: lukas/timetracker#52
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?