Edge case: manual duration of 1 day counts as "session in progress" #58

New Issue

lukas · 2023-10-04T16:05:40Z

lukas commented

2023-10-04 16:05:40 +00:00

To determine whether a session is considered unfinished (in progress), we check if its timestamp_end is null and if seconds of duration_manual is 0¹. However, the DurationField in Django doesn't report total number of seconds, it only reports a remainder that doesn't fit neatly into one of the higher units. Thus when there is an exact amount of 24 hours, it equals 1 day and seconds are set to 0.

games/views.py Line 195 in d2a9630b04

if session.timestamp_end == None and session.duration_manual.seconds == 0:

↩︎

To determine whether a session is considered unfinished (in progress), we check if its `timestamp_end` is null and if seconds of `duration_manual` is 0[^1]. However, the `DurationField` in Django doesn't report total number of seconds, it only reports a remainder that doesn't fit neatly into one of the higher units. Thus when there is an exact amount of 24 hours, it equals 1 day and seconds are set to 0. [^1]: https://git.kucharczyk.xyz/lukas/timetracker/src/commit/d2a9630b048ef3a3a1721d7c1db2abb2902e1aff/games/views.py#L195

lukas referenced this issue from a commit

2023-10-04 16:12:41 +00:00

Fix session being wrongly considered in progress

lukas closed this issue

2023-10-04 16:12:41 +00:00

lukas added spent time 20 minutes

2023-10-04 16:14:49 +00:00

lukas referenced this issue from a commit

2023-11-18 08:23:56 +00:00

Fix session being wrongly considered in progress

Sign in to join this conversation.