Files
timetracker/ts/utils.ts
T
lukas b3fa7fac96 Remove inline-handler → window.* contract (issue #28)
Finish the behavioural refactor from #28: no first-party JS lives on the
global object solely to be reachable from a server-rendered inline on*
attribute, and no inline Alpine blobs remain in the filter bar / year picker.

- Filter-bar collapse: drop the inline onclick for a delegated click listener
  on the persistent <filter-bar> custom element (data-filter-bar-toggle). The
  inner #filter-bar body is htmx-swapped while connectedCallback does not re-run,
  so delegation on the host preserves the swap-survival the inline handler had.
- YearPicker: convert the Alpine x-data/x-on/x-ref/_pickerInstance f-string into
  a <year-picker> custom element with typed props (YearPickerProps). Behavior
  moves to ts/elements/year-picker.ts; ts/year_picker.ts and _YEAR_PICKER_MEDIA
  are removed. The builder lives in primitives.py (next to YearPicker) to avoid a
  circular import; registration stays in custom_elements.py for codegen.
- Add bindPopupDismiss (ts/utils.ts): shared Escape + outside-click dismiss with
  a cleanup return and an extraInside hook for popups mounted on document.body.
  Adopted by date-range-picker.ts (1:1) and year-picker.ts (Datepicker popup is
  body-mounted, passed as an extra inside root).

Follow-up #49 tracks unifying popup/dismiss/positioning across the remaining
dropdown/search-select/Flowbite cases.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-06-20 15:54:00 +02:00

249 lines
9.3 KiB
TypeScript

declare const htmx: any;
/**
* Runs initializeElement once for each element matching selector, on initial
* page load and inside every htmx-swapped fragment (a port of FastHTML's
* proc_htmx). htmx fires htmx:load for the initial document and for each
* swapped-in element, so a single registration covers both; the WeakSet
* guarantees once-per-element initialization, replacing the old
* DOMContentLoaded + htmx:afterSwap + per-element guard-flag pattern.
*/
function onSwap(selector: string, initializeElement: (element: Element) => void) {
const initialized = new WeakSet();
htmx.onLoad((swappedElement: Element) => {
const elements: Element[] = Array.from(htmx.findAll(swappedElement, selector));
if (swappedElement.matches && swappedElement.matches(selector)) {
elements.unshift(swappedElement);
}
for (const element of elements) {
if (initialized.has(element)) continue;
initialized.add(element);
initializeElement(element);
}
});
}
/** Formats Date to a UTC string accepted by the datetime-local input field. */
function toISOUTCString(date: Date): string {
function stringAndPad(number: number) {
return number.toString().padStart(2, "0");
}
const year = date.getFullYear();
const month = stringAndPad(date.getMonth() + 1);
const day = stringAndPad(date.getDate());
const hours = stringAndPad(date.getHours());
const minutes = stringAndPad(date.getMinutes());
return `${year}-${month}-${day}T${hours}:${minutes}`;
}
/**
* Mirrors each source element's value onto its target live as the user types,
* until the user edits the target directly — at which point that target is
* "dirty" and the manual value wins (no more mirroring into it). Each syncData
* entry maps a source selector and property onto a target selector and property.
*/
function syncSelectInputUntilChanged(syncData: Array<{ source: string; target: string; source_value: string; target_value: string }>, parentSelector: string | Document = document) {
const parentElement =
parentSelector === document
? document
: document.querySelector(parentSelector as string);
if (!parentElement) {
console.error(`The parent selector "${parentSelector}" is not valid.`);
return;
}
// One delegated "input" listener drives both directions per syncItem. "input"
// (not "change") makes the mirror live as the user types. A target the user
// edits is marked dirty so the mirror stops clobbering it — programmatically
// setting target.value does NOT fire "input", so our own writes never mark a
// target dirty; only real user edits do.
const dirtyTargets = new Set<number>();
parentElement.addEventListener("input", function (event) {
const eventTarget = event.target as HTMLElement;
syncData.forEach((syncItem, index) => {
// User edited the target directly → stop mirroring into it.
if (eventTarget.matches(syncItem.target)) {
dirtyTargets.add(index);
return;
}
// Source changed → mirror into the target unless the user took it over.
if (eventTarget.matches(syncItem.source) && !dirtyTargets.has(index)) {
const valueToSync = getValueFromProperty(eventTarget, syncItem.source_value);
const targetElement = document.querySelector<HTMLSelectElement>(syncItem.target);
if (targetElement && valueToSync !== null) {
(targetElement as unknown as Record<string, unknown>)[syncItem.target_value] =
valueToSync;
}
}
});
});
}
/**
* Reads a property off the source element. For a <select>, reads from its
* selected option. A "dataset." prefix reads from the element's data-* set.
*/
function getValueFromProperty(sourceElement: EventTarget, property: string): any {
let source: HTMLElement | HTMLOptionElement =
sourceElement instanceof HTMLSelectElement
? sourceElement.selectedOptions[0]
: sourceElement as HTMLElement;
if (property.startsWith("dataset.")) {
let datasetKey = property.slice(8); // Remove 'dataset.' part
return source.dataset[datasetKey];
} else if (property in source) {
return (source as unknown as Record<string, unknown>)[property];
} else {
console.error(`Property ${property} is not valid for the option element.`);
return null;
}
}
interface PopupDismissOptions {
// Clicks within host (or any extraInside root) do not dismiss.
host: HTMLElement;
isOpen: () => boolean;
close: () => void;
// Extra roots considered "inside" — e.g. a library popup appended to
// document.body rather than nested under host. Evaluated per event so a
// lazily-created popup element is picked up once it exists.
extraInside?: () => Array<Element | null | undefined>;
}
/**
* Wires the shared dismiss behaviour for an anchored popup: Escape closes it,
* and a mousedown outside the host (and any extraInside roots) closes it. Only
* acts while isOpen() is true. Returns a cleanup function that removes both
* document listeners — call it from disconnectedCallback.
*/
function bindPopupDismiss(options: PopupDismissOptions): () => void {
const isInside = (target: Node): boolean => {
if (options.host.contains(target)) return true;
const extras = options.extraInside ? options.extraInside() : [];
return extras.some((root) => !!root && root.contains(target));
};
const onKeyDown = (event: KeyboardEvent): void => {
if (event.key === "Escape" && options.isOpen()) options.close();
};
const onMouseDown = (event: MouseEvent): void => {
if (options.isOpen() && !isInside(event.target as Node)) options.close();
};
document.addEventListener("keydown", onKeyDown);
document.addEventListener("mousedown", onMouseDown);
return () => {
document.removeEventListener("keydown", onKeyDown);
document.removeEventListener("mousedown", onMouseDown);
};
}
type ElementHandlerConfig = [
condition: () => boolean, // condition function
targetElements: string[], // array of target element selectors
callbackfn1: (el: HTMLElement) => void, // callback function for matched condition
callbackfn2: (el: HTMLElement) => void // callback function for unmatched condition
];
/**
* For each config, runs callbackfn1 on every target element when condition()
* is true, callbackfn2 otherwise. See ElementHandlerConfig for the tuple shape.
*/
function conditionalElementHandler(...configs: ElementHandlerConfig[]) {
configs.forEach(([condition, targetElements, callbackfn1, callbackfn2]) => {
if (condition()) {
targetElements.forEach((elementName) => {
let el = document.querySelector<HTMLElement>(elementName);
if (el === null) {
console.error(`Element ${elementName} doesn't exist.`);
} else {
callbackfn1(el);
}
});
} else {
targetElements.forEach((elementName) => {
let el = document.querySelector<HTMLElement>(elementName);
if (el === null) {
console.error(`Element ${elementName} doesn't exist.`);
} else {
callbackfn2(el);
}
});
}
});
}
function disableElementsWhenValueNotEqual(
targetSelect: string,
targetValue: string | string[],
elementList: string[]
) {
return conditionalElementHandler([
() => {
let target = document.querySelector<HTMLSelectElement>(targetSelect);
if (!target) return false;
console.debug(
`${disableElementsWhenTrue.name}: triggered on ${target.id}`
);
console.debug(`
${disableElementsWhenTrue.name}: matching against value(s): ${targetValue}`);
if (targetValue instanceof Array) {
if (targetValue.every((value) => target.value != value)) {
console.debug(
`${disableElementsWhenTrue.name}: none of the values is equal to ${target.value}, returning true.`
);
return true;
}
return false;
} else {
console.debug(
`${disableElementsWhenTrue.name}: none of the values is equal to ${target.value}, returning true.`
);
return target.value != targetValue;
}
},
elementList,
(el) => {
console.debug(
`${disableElementsWhenTrue.name}: evaluated true, disabling ${el.id}.`
);
(el as HTMLInputElement).disabled = true;
},
(el) => {
console.debug(
`${disableElementsWhenTrue.name}: evaluated false, NOT disabling ${el.id}.`
);
(el as HTMLInputElement).disabled = false;
},
]);
}
function disableElementsWhenTrue(targetSelect: string, targetValue: string | string[], elementList: string[]) {
return conditionalElementHandler([
() => {
console.log(`${disableElementsWhenTrue.name}: triggered on ${targetSelect}`)
console.log(`Value of ${targetSelect} is ${targetValue}: ${document.querySelector<HTMLSelectElement>(targetSelect)?.value == targetValue}`)
return document.querySelector<HTMLSelectElement>(targetSelect)?.value == targetValue;
},
elementList,
(el) => {
console.log(`${disableElementsWhenTrue.name}: disabling ${el.id}`);
(el as HTMLInputElement).disabled = true;
},
(el) => {
console.log(`${disableElementsWhenTrue.name}: enabling ${el.id}`);
(el as HTMLInputElement).disabled = false;
},
]);
}
export {
onSwap,
toISOUTCString,
syncSelectInputUntilChanged,
conditionalElementHandler,
disableElementsWhenValueNotEqual,
disableElementsWhenTrue,
getValueFromProperty,
bindPopupDismiss,
};